Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #191

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Upgrade golangci-lint, more linters #191

merged 1 commit into from
Feb 14, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 84.49612% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (b5ab305) to head (ec84594).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
receiver_report.go 72.72% 2 Missing and 1 partial ⚠️
rfc8888.go 66.66% 3 Missing ⚠️
sender_report.go 66.66% 1 Missing and 2 partials ⚠️
transport_layer_cc.go 83.33% 3 Missing ⚠️
compound_packet.go 50.00% 1 Missing ⚠️
extended_report.go 90.90% 1 Missing ⚠️
full_intra_request.go 85.71% 0 Missing and 1 partial ⚠️
goodbye.go 75.00% 1 Missing ⚠️
raw_packet.go 50.00% 1 Missing ⚠️
receiver_estimated_maximum_bitrate.go 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   77.90%   77.86%   -0.04%     
==========================================
  Files          22       22              
  Lines        2512     2553      +41     
==========================================
+ Hits         1957     1988      +31     
- Misses        460      470      +10     
  Partials       95       95              
Flag Coverage Δ
go 77.86% <84.49%> (-0.04%) ⬇️
wasm 77.86% <84.49%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki merged commit ec84594 into master Feb 14, 2025
15 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch February 14, 2025 11:34
@JoeTurki JoeTurki mentioned this pull request Feb 14, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant